fix: add validation for envoy gateway watch mode field and update doc #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawnh2 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2431 +/- ##
==========================================
- Coverage 64.72% 64.70% -0.02%
==========================================
Files 115 115
Lines 17402 17415 +13
==========================================
+ Hits 11264 11269 +5
- Misses 5424 5431 +7
- Partials 714 715 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shawnh2 <[email protected]>
arkodg
reviewed
Jan 11, 2024
Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: sh2 <[email protected]>
Signed-off-by: Shawnh2 <[email protected]>
zirain
approved these changes
Jan 12, 2024
Xunzhuo
approved these changes
Jan 13, 2024
zesiar0
pushed a commit
to zesiar0/gateway
that referenced
this pull request
Jan 22, 2024
…envoyproxy#2431) * add validate for envoy gateway watch mode field and update doc Signed-off-by: Shawnh2 <[email protected]> * resolve ci and update doc types Signed-off-by: Shawnh2 <[email protected]> * Update api/v1alpha1/envoygateway_types.go Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: sh2 <[email protected]> * resolve gen-check Signed-off-by: Shawnh2 <[email protected]> --------- Signed-off-by: Shawnh2 <[email protected]> Signed-off-by: sh2 <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Signed-off-by: A3bz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2430